Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fetch() trace span #586

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix: fix fetch() trace span #586

merged 2 commits into from
Jun 25, 2024

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Jun 25, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

e.g.

image

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#577

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added bug Something isn't working perf Performance optimization labels Jun 25, 2024
@MrCroxx MrCroxx added this to the v0.10 milestone Jun 25, 2024
@MrCroxx MrCroxx self-assigned this Jun 25, 2024
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.07%. Comparing base (2146ab6) to head (d0becdb).

Files Patch % Lines
foyer-common/src/trace.rs 77.27% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   86.21%   86.07%   -0.14%     
==========================================
  Files          59       59              
  Lines        7602     7570      -32     
==========================================
- Hits         6554     6516      -38     
- Misses       1048     1054       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit 92f354c into main Jun 25, 2024
16 checks passed
@MrCroxx MrCroxx deleted the xx/fft branch June 25, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working perf Performance optimization
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant