refactor: simplify some generic type definition #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCroxx
approved these changes
Jul 25, 2023
| <<A as Adapter>::PointerOps as PointerOps>::Pointer: Clone, | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
(Is the empty line between automated added by IDE? Or some format setting needs to be enabled? I'll enable it by default.
| @@ -15,6 +15,7 @@ | |||
| #![feature(associated_type_bounds)] | |||
| #![feature(ptr_metadata)] | |||
| #![feature(trait_alias)] | |||
| #![feature(return_position_impl_trait_in_trait)] | |||
| ) -> impl Iterator<Item = &'_ <<Self::Adapter as Adapter>::PointerOps as PointerOps>::Pointer> + '_; | ||
| } | ||
|
|
||
| pub trait EvictionPolicyExt: EvictionPolicy { |
| @@ -25,12 +25,9 @@ use parking_lot::Mutex; | |||
| use std::hash::Hasher; | |||
| use twox_hash::XxHash64; | |||
|
|
|||
| pub struct CacheConfig<K, V, E, EL> | |||
| pub struct CacheConfig<E> | |||
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 67.19% 67.16% -0.03%
==========================================
Files 33 33
Lines 4682 4678 -4
==========================================
- Hits 3146 3142 -4
Misses 1536 1536
|
MrCroxx
pushed a commit
that referenced
this pull request
Apr 17, 2024
* refactor: simplify some generic type definition * run clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.