Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove index when storage lookup miss #99

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Aug 1, 2023

What's changed and what's your intention?

As titled.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have passed make check and make test in my local envirorment.

Related issues or PRs (optional)

close #94

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the feature New feature or request label Aug 1, 2023
@MrCroxx MrCroxx self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #99 (dbf02a4) into main (d3b2972) will increase coverage by 0.80%.
Report is 2 commits behind head on main.
The diff coverage is 96.46%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   66.80%   67.60%   +0.80%     
==========================================
  Files          40       41       +1     
  Lines        4944     5091     +147     
==========================================
+ Hits         3303     3442     +139     
- Misses       1641     1649       +8     
Files Changed Coverage Δ
foyer-intrusive/src/eviction/mod.rs 64.70% <ø> (ø)
foyer-storage/src/region_manager.rs 94.56% <ø> (-0.06%) ⬇️
foyer-intrusive/src/eviction/sfifo.rs 95.85% <95.85%> (ø)
foyer-intrusive/src/eviction/fifo.rs 94.00% <100.00%> (-1.82%) ⬇️
foyer-memory/src/lib.rs 98.55% <100.00%> (ø)
foyer-storage/src/store.rs 83.64% <100.00%> (+0.05%) ⬆️

@MrCroxx MrCroxx merged commit 0e5a595 into main Aug 1, 2023
7 checks passed
@MrCroxx MrCroxx deleted the xx/remove-index-on-miss branch August 1, 2023 16:11
MrCroxx added a commit that referenced this pull request Apr 17, 2024
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove entry index when checksum mismatch
1 participant