-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add strict option for defaultConverter #231
Conversation
formatDistanceToNow: less than a minute ago formatDistanceToNowStrict: 0 seconds ago
Hey @srabouin! Thanks alot for your PR! :) You should already be able to use But in all honesty, i have no issue with merging your PR as it is a good addition to the default converter. In order to get it merged, it would be cool if you could adjust the related docs for the
If you want to, you can also add a simple test case for the new converterOption: Thanks! |
I added the docs and the example, noticed the example was using the wrong version so I also updated that. Hope this helps! |
Hey @srabouin! Your change was just released in v2.2.0. Thanks again for your contribution! :) |
Awesome, thanks for fixing the little things :) |
formatDistanceToNow:
less than a minute ago
formatDistanceToNowStrict:
0 seconds ago