ModuleWithProviders GenericType #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrFrankel can you merge this? |
hakimio
added a commit
to hakimio/ngx-tour
that referenced
this pull request
Aug 10, 2020
… Angular 10. See MrFrankel/ngx-popper/pull/143 for more info.
|
Can you please merge this PR?. We ran into this problem while we are upgrading the angular |
|
@zlajson and @prabhakerb I fixed this in my version of the lib... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I run into following issue while updating to angular 10:
ERROR: node_modules/ngx-popper/src/popper.module.d.ts:5:63 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s).
More info can be found here.
Please let me know if there is something I missed.