Skip to content

Commit

Permalink
build: fix release notes script bug that omitted edited release-clerk…
Browse files Browse the repository at this point in the history
… comments (electron#40634)

* build: fix release notes script bug that omitted edited release-clerk comments

add a warning when neither notes nor no-notes are found

* fixup! build: fix release notes script bug that omitted edited release-clerk comments

use console.warn() instead of console.log()
  • Loading branch information
ckerr authored and MrHuangJser committed Dec 11, 2023
1 parent 405b562 commit d4b3333
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion script/release/notes/notes.js
Expand Up @@ -99,7 +99,7 @@ const getNoteFromClerk = async (ghKey) => {

const CLERK_LOGIN = 'release-clerk[bot]';
const CLERK_NO_NOTES = '**No Release Notes**';
const PERSIST_LEAD = '**Release Notes Persisted**\n\n';
const PERSIST_LEAD = '**Release Notes Persisted**';
const QUOTE_LEAD = '> ';

for (const comment of comments.data.reverse()) {
Expand Down Expand Up @@ -130,6 +130,8 @@ const getNoteFromClerk = async (ghKey) => {
.trim();
}
}

console.warn(`WARN: no notes found in ${buildPullURL(ghKey)}`);
};

/**
Expand Down

0 comments on commit d4b3333

Please sign in to comment.