Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Some Custom Cycles are Broken #208

Closed
2 tasks done
Soft-Bred opened this issue Feb 7, 2024 · 9 comments Β· Fixed by #218
Closed
2 tasks done

πŸ› Some Custom Cycles are Broken #208

Soft-Bred opened this issue Feb 7, 2024 · 9 comments Β· Fixed by #218
Assignees
Labels

Comments

@Soft-Bred
Copy link
Sponsor Contributor

Bug Description

Some custom cycles don't work; they just make the window as small as it supports and shove it to the top-left corner.

Steps To Reproduce

  1. Import attached config
  2. Open any app
  3. Try use ⌘ βŒ₯ βŒƒ ⇧ M (repeatedly)
  4. Watch as it fails
  5. Try use ⌘ βŒ₯ βŒƒ ⇧ P (repeatedly)
  6. Watch as it fails
  7. Try use ⌘ βŒ₯ βŒƒ ⇧ D (repeatedly)
  8. Watch as it works for some reason

Expected Behavior

The actual positions are respected.

Actual Behavior

The window as small as it supports and shove it to the top-left corner.

Screenshots

004382.-.01.mp4

MacOS Version

14.2.1 (23C71)

Loop Version

Version 1.0.0-beta.14 (686)

Additional Context

keybinds.json

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@Soft-Bred Soft-Bred added the Bug label Feb 7, 2024
@MrKai77 MrKai77 self-assigned this Feb 8, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Feb 8, 2024

Hmm I tried it on my side and I can't seem to reproduce it..
I also tried it with the same Warp terminal but still couldn't reproduce it :(

do you think there's any more information you could provide? Maybe your display resolution or scaling option? And I'm assuming that it worked perfectly before?

If that's the case, just verifying that the build you downloaded was from #196?

@Soft-Bred
Copy link
Sponsor Contributor Author

do you think there's any more information you could provide?

  • This still happens when 1 display is connected
  • This happens regardless of resolution (2056 Γ— 1329) on my laptop screen
  • This only occurs when the actions in a cycle are "custom."
  • The preview works fine when enabled, but letting go puts the window in the incorrect position
  • None of the settings in the Radial Menu change this
  • It used to work before πŸ› Skip "Next/Previous Screen" if no screen detectedΒ #196

@MrKai77
Copy link
Owner

MrKai77 commented Feb 10, 2024

Interesting.. I'll look into what code changes I made and try and backtrack to the last working version!

@MrKai77
Copy link
Owner

MrKai77 commented Feb 16, 2024

I was finally able to reproduce it!! I will definitely fix this soon!

@Soft-Bred
Copy link
Sponsor Contributor Author

;0 what were the repro steps? Was I somewhat wrong?

@MrKai77
Copy link
Owner

MrKai77 commented Feb 16, 2024

The weird part is that I don't have any repro steps 😭
It randomly started and now it's not going away at all haha..

@MrKai77
Copy link
Owner

MrKai77 commented Feb 16, 2024

Anyways, here's the issue:
image
It's trying to resize the window to "infinity" (and I have no idea how it got there) πŸ˜…

@MrKai77
Copy link
Owner

MrKai77 commented Feb 16, 2024

This should work! Looks like I was using the wrong screenFrame variable in the calculations :)
Loop.zip

@MrKai77 MrKai77 linked a pull request Feb 16, 2024 that will close this issue
@Soft-Bred
Copy link
Sponsor Contributor Author

fixed :)

MrKai77 added a commit that referenced this issue Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants