Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Preview window should show new proposed size when centering a window #46

Closed
AISLVE opened this issue Sep 30, 2023 · 2 comments · Fixed by #47
Closed

🐛 Preview window should show new proposed size when centering a window #46

AISLVE opened this issue Sep 30, 2023 · 2 comments · Fixed by #47
Assignees
Labels

Comments

@AISLVE
Copy link

AISLVE commented Sep 30, 2023

Bug Description

So there is a bug when switching from maximized to center position

Steps To Reproduce

  1. Go to fullscreen method by clicking right command twice(in my case) + space
  2. Try going to center position by clicking right command twice + enter

Expected Behavior

Should go to center mode with a smaller windows

Actual Behavior

Doesn't resize and remains as it is

screen recording: https://we.tl/t-2sIOOzxZce

Screenshots

No response

MacOS Version

Sonoma 14, public beta

Loop version

1.0.0-beta.10 (351)

Additional Context

No response

@AISLVE AISLVE added the Bug label Sep 30, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Sep 30, 2023

Thanks for the bug report!
Actually, how it happens now is the intended behaviour when centering a window, but the preview window happens to make it look like it should become smaller.
The real bug I should be fixing here is to make the preview window show the new proposed size of the window, rather than showing the a "insetted maximize" shape.

Expected Behavior: Should go to center mode with a smaller windows

If you want to add a bit of padding around the edges of the window to your windows, there's a "Window Padding" setting you can configure in Loop's settings :)

@MrKai77 MrKai77 self-assigned this Sep 30, 2023
@MrKai77 MrKai77 changed the title 🐛 Centering bug 🐛 Preview window should show new proposed size when centering window Sep 30, 2023
@MrKai77 MrKai77 changed the title 🐛 Preview window should show new proposed size when centering window 🐛 Preview window should show new proposed size when centering a window Sep 30, 2023
MrKai77 added a commit that referenced this issue Sep 30, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Sep 30, 2023

Here's a fixed build!
Loop.zip

MrKai77 added a commit that referenced this issue Sep 30, 2023
…new-proposed-size-when-centering-a-window`

🐛 #46 Preview window should show new proposed size when centering a window
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants