Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Trigger Key and conflicts #74

Closed
2 tasks done
Zabriskije opened this issue Oct 28, 2023 · 10 comments · Fixed by #123
Closed
2 tasks done

🐛 Trigger Key and conflicts #74

Zabriskije opened this issue Oct 28, 2023 · 10 comments · Fixed by #123
Assignees
Labels

Comments

@Zabriskije
Copy link

Zabriskije commented Oct 28, 2023

Bug Description

Loop gets triggered whenever the trigger key is pressed alone or in combination with other keys; this frequently conflicts with other keybindings, making them unusable.

Steps To Reproduce

  1. Set Trigger Key to left Command
  2. Open Safari
  3. Try to open a new tab with left Command+Shift+N

Expected Behavior

Loop should let me open a new Safari tab

Actual Behavior

Loop intercepts the key and makes Command+Shift+N impossible, since pressing Command alone triggers the app

Screenshots

No response

MacOS Version

Sonoma 14.0 (23A344)

Loop Version

1.0.0-beta.11 (465)

Additional Context

I'm using Caps Lock as Hyper Key (), and every time I press it, Loop gets triggered and I can't call my custom key bind (if Loop is set to any keys in the left side of the keyboard).

It would be nice to make Loop recognize when its key is being used alone or when a combination of keys is pressed so it won't get triggered, paired with the option to remove the trigger key altogether or set it to multiple trigger keys instead of just one.

I know there's the option to make the trigger key only work when it's double pressed – and this partially solves the issue – but I'd love to use Hyper Key for Loop. However, I don't know if that would be feasible since it invokes Loop and takes control of that key combination. I'm not informed enough to understand what is happening under the hood, but apps like Moom or Rectangle do not conflict with other apps in which I'm using the Hyper Key such as Raycast or macOS System Settings.

Perhaps if it's just the Radial Menu, add an option to disable it or activate it only when the Keybinds are pressed? So you'll be able to see the preview anyway but it won't affect other key combinations.

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@MrKai77
Copy link
Owner

MrKai77 commented Oct 28, 2023

Perhaps if it's just the Radial Menu, add an option to disable it or activate it only when the second key is pressed? So you'll be able to see the preview anyway but it won't affect other key combinations.

Interesting approach! I'll look into this! This should indeed allow the user to use other keybinds in other apps!
As for the Hyper Key, I'll have to intestigate that too! Making sure that it's pressed alone should work!

EDIT: I'll be working on this once I get #75 done!

@Zabriskije
Copy link
Author

Edit: I had read the description of my issue again and found that instead of "second key" I meant "Keybinds" (last sentence), so I fixed it.

@MrKai77
Copy link
Owner

MrKai77 commented Dec 5, 2023

Thanks!
Just letting you know that this issue is my priority for Loop right now.
Unfortunately, I've been quite busy lately, but I assure you that I am committed to implementing this as soon as my schedule allows for it :)

@Zabriskije
Copy link
Author

No pressure. It's already great to see so much passion and dedication :)
Stars keep coming, so it's a matter of time until someone lends an extra hand.

MrKai77 added a commit that referenced this issue Dec 19, 2023
MrKai77 added a commit that referenced this issue Dec 19, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Dec 20, 2023

Alright, here's a build that should work! You can find the setting under the "Radial Menu" tab of the settings window.
Loop.zip

@Zabriskije
Copy link
Author

Conflicts with other keys are gone, but now Middle-click to trigger Loop doesn't work/show up anymore until you press a direction key. When Hide until direction is chosen is disabled, the radial menu shows up but still doesn't work with the mouse until you press a direction key.

Middle-click bug

MrKai77 added a commit that referenced this issue Dec 21, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Dec 21, 2023

I can't believe that the fix was a in a single line of code 😂
But now it works! Here's the latest build:
Loop.zip

@Zabriskije
Copy link
Author

Middle-click to trigger Loop seems to work fine now, but when Hide until direction is chosen is enabled, Window Snapping keeps showing the preview until another middle-click action is made.

Window Snapping bug

MrKai77 added a commit that referenced this issue Dec 22, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Dec 22, 2023

Fixed!
Loop.zip

@Zabriskije
Copy link
Author

Everything seems to work properly 🥳 good job!

@MrKai77 MrKai77 linked a pull request Dec 22, 2023 that will close this issue
@njthebaud njthebaud mentioned this issue Apr 4, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants