-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Trigger Key and conflicts #74
Comments
Interesting approach! I'll look into this! This should indeed allow the user to use other keybinds in other apps! EDIT: I'll be working on this once I get #75 done! |
Edit: I had read the description of my issue again and found that instead of "second key" I meant "Keybinds" (last sentence), so I fixed it. |
Thanks! |
No pressure. It's already great to see so much passion and dedication :) |
Alright, here's a build that should work! You can find the setting under the "Radial Menu" tab of the settings window. |
I can't believe that the fix was a in a single line of code 😂 |
Fixed! |
Everything seems to work properly 🥳 good job! |
Bug Description
Loop gets triggered whenever the trigger key is pressed alone or in combination with other keys; this frequently conflicts with other keybindings, making them unusable.
Steps To Reproduce
Expected Behavior
Loop should let me open a new Safari tab
Actual Behavior
Loop intercepts the key and makes Command+Shift+N impossible, since pressing Command alone triggers the app
Screenshots
No response
MacOS Version
Sonoma 14.0 (23A344)
Loop Version
1.0.0-beta.11 (465)
Additional Context
I'm using Caps Lock as Hyper Key (⌃⌥⌘⇧), and every time I press it, Loop gets triggered and I can't call my custom key bind (if Loop is set to any keys in the left side of the keyboard).
It would be nice to make Loop recognize when its key is being used alone or when a combination of keys is pressed so it won't get triggered, paired with the option to remove the trigger key altogether or set it to multiple trigger keys instead of just one.
I know there's the option to make the trigger key only work when it's double pressed – and this partially solves the issue – but I'd love to use Hyper Key for Loop. However, I don't know if that would be feasible since it invokes Loop and takes control of that key combination. I'm not informed enough to understand what is happening under the hood, but apps like Moom or Rectangle do not conflict with other apps in which I'm using the Hyper Key such as Raycast or macOS System Settings.
Perhaps if it's just the Radial Menu, add an option to disable it or activate it only when the Keybinds are pressed? So you'll be able to see the preview anyway but it won't affect other key combinations.
Final Checks
The text was updated successfully, but these errors were encountered: