Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Custom window padding on each side of screen #94

Closed
2 tasks done
M4cs opened this issue Nov 29, 2023 · 15 comments · Fixed by #202
Closed
2 tasks done

✨ Custom window padding on each side of screen #94

M4cs opened this issue Nov 29, 2023 · 15 comments · Fixed by #202
Assignees
Labels

Comments

@M4cs
Copy link

M4cs commented Nov 29, 2023

Feature Request Description

Loop is lovely so far. Really love the intuitive feeling of the gestures as well as the animations, I use yabai for automated window management and have some custom window size settings since I'm using apps like Ubersicht for custom task bars.

Would be great if when using Loop, they would respect these window gaps and borders.

Screenshots

What window looks like with yabai window gaps normally:

image

What window looks like after loop resizing:

image

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single feature request (multiple feature requests should be reported individually)
@M4cs M4cs added the Feature label Nov 29, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Nov 30, 2023

Thanks for this feature request!
Would this mean that Loop would read Yabai’s settings from the .config folder at the root of the user’s account?
I haven’t used Yabai much, but I’m definitely open to implementing this :)

@MrKai77 MrKai77 self-assigned this Nov 30, 2023
@M4cs
Copy link
Author

M4cs commented Dec 6, 2023

Thanks for this feature request! Would this mean that Loop would read Yabai’s settings from the .config folder at the root of the user’s account? I haven’t used Yabai much, but I’m definitely open to implementing this :)

I think that would probably be easiest, not sure if there's a way to actually read from the yabai daemon or something but that would be optimal. Loop has been great so far! With some of the extra padding in the settings I was able to get it close to the window gaps I need but not quite.

@yougotwill
Copy link

@MrKai77 Another way to resolve this would be to allow window padding per side like in Amethyst instead of 1 padding value for all sides. Didn't want to open a new issue for a similar problem. Would love to have this feature implemented.

Screenshot 2024-01-22 at 16 51 57

@MrKai77
Copy link
Owner

MrKai77 commented Jan 22, 2024

Ohh yeah actually I like that idea! I can probably make a UI similar to the custom keybind UI. I don't know if I will be able to finish that before the next release though :)

@yougotwill
Copy link

@MrKai77 Thank you for your quick reply. I understand it might not be in the next release but would love to have it as soon as you can. Would make loop a perfect complement to amethyst or yabai 😊 Really enjoying how smooth it is.

@MrKai77 MrKai77 changed the title ✨ Respect yabai window sizing when moving windows ✨ Custom window padding on each side of screen Jan 24, 2024
MrKai77 added a commit that referenced this issue Feb 4, 2024
MrKai77 added a commit that referenced this issue Feb 4, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Feb 4, 2024

Sorry for the wait! Here's a build with the changes:
Loop.zip

Screenshot 😎:
Screenshot 2024-02-03 at 10 09 00 PM

@MrKai77 MrKai77 linked a pull request Feb 4, 2024 that will close this issue
MrKai77 added a commit that referenced this issue Feb 4, 2024
…ach-side-of-screen`

✨ #94 Custom window padding on each side of screen
@yougotwill
Copy link

Hi @MrKai77 I assume the zip you uploaded is now outdated so I can't test until the release?

@MrKai77
Copy link
Owner

MrKai77 commented Feb 5, 2024

Whoops sorry!
I forgot to upload a new version :(
Here's an updated one:
Loop.zip

@yougotwill
Copy link

@MrKai77 One issue I have with this design for screen padding is there is no way to know the value on the slider? Like what is 5 pixels? I have to take 50px and divide up the notches or something.

Not sure you how want to display the current value but I suggest maybe when you grab the notch it shows the value above it as a tooltip or something?

@yougotwill
Copy link

and when you drag it updates

@MrKai77
Copy link
Owner

MrKai77 commented Feb 5, 2024

One issue I have with this design for screen padding is there is no way to know the value on the slider? Like what is 5 pixels? I have to take 50px and divide up the notches or something.

You can toggle "Use Custom Values" near the top to enter your own values :)
Also, the slider goes up by increments of 5 every time.

@yougotwill
Copy link

yougotwill commented Feb 5, 2024

You can toggle "Use Custom Values" near the top to enter your own values :)

That is good. I did see that.

Also, the slider goes up by a value to 5 every time.

Might be good to explain this somewhere. Just for noobie users 🙏

Sorry if I'm going overboard. It works perfectly with amethyst though so now loop is upgraded to being a daily driver for me. Thank you!

@MrKai77
Copy link
Owner

MrKai77 commented Feb 5, 2024

Sorry if I'm going overboard. It works perfectly with amethyst though so now loop is upgraded to being a daily driver for me. Thank you!

No problem!

Might be good to explain this somewhere. Just for noobie users 🙏

Yeah now that I'm thinking about it, it might be better to simply remove the sliders in the first place (and stick with only the text boxes), to reduce complexity.

MrKai77 added a commit that referenced this issue Feb 5, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Feb 5, 2024

here's a build without those sliders!
Loop.zip

@yougotwill
Copy link

Perfect. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants