-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 1.20.4 fixed formatting #46
Conversation
Thank you for your pull request but I’m not sure to understand exactly how it would look in game and the advantages of this, if you could provide an ingame screenshot with the explanations about the advantages for this, it would be perfect! Thanks |
Any news on this pr? I found this very usefull and seems ready to be merged |
Hi, sorry for the long delay, I've pushed some changes with the goal of simplify cross-version (between pre and post 1.20.3) handling: the behavior of the scores is always the same, but of course the custom scores are only displayed on 1.20.3+ Reviews & comments are welcome :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice additions!
Co-authored-by: syldium <syldium@mailo.com>
Good catches @syldium , thanks! |
This PR adds support for the 1.20.4 fixed formatting for the scoreboard scores. I tested this on Paper 1.19.4 so backwards compatibility should be working. The only underlying change to the protocol is the
FixedFormat
NMS objects that get sent fromsendModernScorePacket()
instead ofBlankFormat
objects if the score's text has been set.