Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow normal players to reload the plugin #45

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

skbeh
Copy link
Contributor

@skbeh skbeh commented Mar 25, 2023

No description provided.

@MrMicky-FR
Copy link
Owner

Thanks, it’s a good catch! Just why remove the customization of the permission message through the config? Because server owners may want to add specific information on why the player can’t use WESV (maybe only in specific works, or for higher ranks - just some examples)

@skbeh
Copy link
Contributor Author

skbeh commented Mar 25, 2023

Because bukkit already has the default no-permission message and I think that it is good enough.

@MrMicky-FR
Copy link
Owner

It may be good enough, but I don’t see the point of removing the message customization without a specific reason

@MrMicky-FR MrMicky-FR merged commit c20cabe into MrMicky-FR:master Mar 25, 2023
@MrMicky-FR
Copy link
Owner

Thanks :)

@skbeh skbeh deleted the permission-fix branch March 26, 2023 01:07
@skbeh
Copy link
Contributor Author

skbeh commented Mar 26, 2023

@MrMicky-FR The permissions are already granted to all player because of default: true. So the wildcard permission should not be granted by default.
The correct one:

  wesv.*:
    default: false
    children:
      wesv.use: true
      wesv.toggle: true
      wesv.lock: true
      wesv.reload: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants