Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "--gpus all" and other possible container properties #20

Open
Tiendil opened this issue Jul 23, 2021 · 1 comment
Open

Support for "--gpus all" and other possible container properties #20

Tiendil opened this issue Jul 23, 2021 · 1 comment
Labels
✨ enhancement New feature or request

Comments

@Tiendil
Copy link

Tiendil commented Jul 23, 2021

Hi!

First of all, great project! Is it still alive? There is no activity since April.

In continue of discussion in gh-19.

I looked into possible ways of implementing support for --gpus all cli argument and other arguments of docker.containers.run.

There are a lot of arguments for docker.containers.run, besides device_requests (throught which --gpus all implemented). Most of them are useful in one or another way. It seems to me, there is no good way to specify them all as command-line arguments for dockernel .

What do you think about other ways?

  • Command-line argument to specify custom runner script for container, where user can configure all required properties;
  • Command-line argument to specify separated config for the container, from which dockernel will get arguments for docker.containers.run.

The config file may need to use Python, since docker.containers.run requires complex data structures, like docker.types.DeviceRequest. So, the first approach fills easier to implement and use.

@MrMino
Copy link
Owner

MrMino commented Jul 23, 2021

Hi

First of all, great project! Is it still alive? There is no activity since April.

Thanks! :) It's alive. I decided to shift my attention to wheelfile and IPython for now, but I'm still planning to move this forward - I'd like to pick up the slack in the next week or two, depending on how much time I'll have for OSS work.

The config file may need to use Python, since docker.containers.run requires complex data structures, like docker.types.DeviceRequest. So, the first approach fills easier to implement and use.

I wanted to implement a config scheme and add different options incrementally. I haven't thought it through yet though - e.g. I'm not sure whether these options should be remembered inside the kernelspec too. I will have to test it out.

I'm certainly against the idea of having an executable script that provides the config (ala setuptools). I'd like it to be either TOML, JSON or YAML (maybe something similar to docker-compose?).

The details are TBD, but most likely there will be a "config lookup" mechanism similar to pyenv's - a .dockernel file will be searched for up the filesystem tree, parsed into a dict, merged with other config files, and the kernels will be run based on that.

@MrMino MrMino added the ✨ enhancement New feature or request label Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants