Skip to content

Commit

Permalink
Remove opacity changes from titlebar - fixes #331
Browse files Browse the repository at this point in the history
Bug 1870803 introduced a transition to window activeness visuals. But
the lowered opacity breaks the z-index hackery we use to let
window-controls show through nav-bar.

This patch basically undoes the changes from bug 1870803
  • Loading branch information
MrOtherGuy committed Dec 22, 2023
1 parent 9830ab5 commit df4462f
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 5 deletions.
6 changes: 5 additions & 1 deletion chrome/hide_tabs_toolbar.css
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ Window controls will be all wrong without it

:root[tabsintitlebar]{ --uc-toolbar-height: 40px; }
:root[tabsintitlebar][uidensity="compact"]{ --uc-toolbar-height: 32px }

#titlebar{
will-change: unset !important;
transition: none !important;
opacity: 1 !important;
}
#TabsToolbar{ visibility: collapse !important }

:root[sizemode="fullscreen"] #TabsToolbar > :is(#window-controls,.titlebar-buttonbox-container){
Expand Down
7 changes: 6 additions & 1 deletion chrome/hide_tabs_toolbar_w_alltabs_button.css
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,9 @@ See the above repository for updates as well as full license text. */
#TabsToolbar > .titlebar-spacer{ display: none }
#TabsToolbar:not([customizing]){ margin-bottom: calc(0px - var(--tab-min-height) - 2 * var(--tab-block-margin))}

#titlebar{ -moz-appearance: none !important; }
#titlebar{
-moz-appearance: none !important;
will-change: unset !important;
transition: none !important;
opacity: 1 !important;
}
7 changes: 6 additions & 1 deletion chrome/hide_tabs_with_one_tab_w_window_controls.css
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ Window controls will be all wrong without it
:root{
--uc-menubar-vertical-overlap: 28px; /* adjust as necessary */
}
#titlebar{ -moz-appearance: none !important; }
#titlebar{
-moz-appearance: none !important;
will-change: unset !important;
transition: none !important;
opacity: 1 !important;
}
/* We'll use window controls from menubar instead */
#TabsToolbar > .titlebar-buttonbox-container { display: none }
/* Hide overflow button unless tabs overflow - is necessary for collpasing tabs with one tab */
Expand Down
6 changes: 5 additions & 1 deletion chrome/navbar_tabs_oneliner_tabs_on_left.css
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ Window controls will be all wrong without it
--uc-toolbar-height: 40px;
--uc-urlbar-min-width: 50vw; /* minimum width for opened urlbar */
}

#titlebar{
will-change: unset !important;
transition: none !important;
opacity: 1 !important;
}
#scrollbutton-up,
#scrollbutton-down{ border-block-width: 2px !important; }

Expand Down
6 changes: 5 additions & 1 deletion chrome/tabs_below_content.css
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ linux_gtk_window_control_patch.css
z-index: 3;
visibility: visible !important;
}

#titlebar{
will-change: unset !important;
transition: none !important;
opacity: 1 !important;
}
@media (-moz-bool-pref: "userchrome.force-window-controls-on-left.enabled"),
(-moz-gtk-csd-reversed-placement),
(-moz-platform: macos){
Expand Down

0 comments on commit df4462f

Please sign in to comment.