Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drop extension fuinctions #237

Closed
3 tasks
SemyonSinchenko opened this issue Jul 11, 2024 · 1 comment
Closed
3 tasks

feat: Drop extension fuinctions #237

SemyonSinchenko opened this issue Jul 11, 2024 · 1 comment
Assignees
Labels
1.0 Quinn 1.0 release

Comments

@SemyonSinchenko
Copy link
Collaborator

Feature Type

  • Adding new functionality to quinn

  • Changing existing functionality in quinn

  • Removing existing functionality in quinn

Problem Description

Extension functions are deprecated for a long time, we should drop them from 1.0

Feature Description

Drop them:

Additional Context

No response

@SemyonSinchenko SemyonSinchenko added the 1.0 Quinn 1.0 release label Jul 11, 2024
@nijanthanvijayakumar
Copy link
Contributor

@SemyonSinchenko - can I take this up please?

nijanthanvijayakumar added a commit to nijanthanvijayakumar/quinn that referenced this issue Jul 11, 2024
Related to MrPowers#237

Remove deprecated extension functions from the codebase
* Delete `quinn/extensions/dataframe_ext.py` and `quinn/extensions/spark_session_ext.py`
* Remove import statements for `dataframe_ext` and `spark_session_ext` in `quinn/extensions/__init__.py`
* Remove per-file ignores for `quinn/extensions/dataframe_ext.py` and `quinn/extensions/__init__.py` in `pyproject.toml`
* Delete test files `tests/extensions/test_dataframe_ext.py` and `tests/extensions/test_spark_session_ext.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Quinn 1.0 release
Projects
None yet
Development

No branches or pull requests

2 participants