Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split-dependencies-into-groups #129

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

dinjazelena
Copy link
Contributor

@dinjazelena dinjazelena commented Sep 29, 2023

Closes #128

a). Split dev-dependencies into:
1. development group
2. testing group
3. linting group
4. docs group

b) Created Makefile with few common commands.

c) Updated ruff.yaml
1. Added trigger for every push(lint should always run)
2. Renamed job to Lint(Since i guess in future there should be black and mypy beside ruff)

@dinjazelena
Copy link
Contributor Author

@MrPowers , Is there a reason for having exact versions of pytest, chipsa,ruff, semver?

I did put caret sign so pytest were updated from 7.4.0 to 7.4.2 and chipsa from 0.9.2 to 0.9.3.

@dinjazelena
Copy link
Contributor Author

Ruff only enables Pycodestyle and Pyflakes which is kinda very shallow pythonic pep8 check. You should
select = ['ALL'] and then ignore the ones according to your preferences.

@dinjazelena
Copy link
Contributor Author

@MrPowers , Is there a specific reason for using custom gh action for running ruff? Do u plan introducing mypy and black?

@SemyonSinchenko
Copy link
Collaborator

The problem here is we are not able to test new actions until we merge it. But I do not see a big problem even if we break CI. So, LGTM.

@dinjazelena May we add to linting also a spell-checking for a README.md file?

@dinjazelena
Copy link
Contributor Author

@SemyonSinchenko , what exactly can we use for spell-checking?

@SemyonSinchenko
Copy link
Collaborator

Something like this or any similar solution.

@MrPowers
Copy link
Owner

LGTM

@MrPowers MrPowers merged commit 8d99f94 into MrPowers:main Sep 29, 2023
@MrPowers
Copy link
Owner

@dinjazelena - this project also needs dependencies split into groups: pyspark-ai/pyspark-ai#137

This is a good opportunity to contribute to another project that's run by the PySpark core devs if you're interested.

Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split dev-dependencies into multiple groups
3 participants