Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests on latest version of Spark #206

Merged

Conversation

kunaljubce
Copy link
Contributor

@kunaljubce kunaljubce commented Feb 23, 2024

v1 of CI workflow to run all tests on latest version of Spark after PR creation.

Addresses Issue #203

.github/workflows/pr.yml Outdated Show resolved Hide resolved
.github/workflows/pr.yml Outdated Show resolved Hide resolved
kunaljubce and others added 2 commits February 23, 2024 21:39
Co-authored-by: Semyon <semyonsinchenko@yahoo.com>
Co-authored-by: Semyon <semyonsinchenko@yahoo.com>
@kunaljubce kunaljubce changed the title [WIP DONT MERGE] Add CI tests on latest version of Spark Add CI tests on latest version of Spark Feb 23, 2024
@kunaljubce
Copy link
Contributor Author

kunaljubce commented Feb 23, 2024

@SemyonSinchenko @MrPowers The assumption of this solution is that we are treating the Spark version in our poetry.lock as the latest Spark version. Is that a fair one to begin with?

I am also planning to add a condition to the CI to ignore changes to docs/, CONTRIBUTING.md and README.md. I am not sure how far this is possible, definitely unchartered territory for me but will still try. Let me know your thoughts!

Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for that contribution!

@SemyonSinchenko SemyonSinchenko merged commit bd6b6e2 into MrPowers:main Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants