Fix surround substring to surround all substrings #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #209
Types of changes
What types of changes does your code introduce to quinn?
Put an
x
in the boxes that applyFurther comments
I changed the
input.find
-method to simply useinput.replace
in order to replace all occurrences of the keyword. It will also replace substrings inside words, which I'm not sure is intentional (see 3rd unit test). Should the substring only be surrounded if there are no alphabetical characters, or maybe no alphanumerical characters around it? I.e.rdd
inspark rdd stuff
would be surrounded:spark **rdd|| stuff
rdd
inspark rddrdd stuff
would be surrounded:spark **rdd||**rdd|| stuff
rdd
inspark rdd123 stuff
would be surrounded:spark **rdd||123 stuff
rdd
inspark rdd stuff
would be surrounded:spark **rdd|| stuff
rdd
inspark rddrdd stuff
would not be surrounded:spark rdd stuff
rdd
inspark rdd123 stuff
would be surrounded:spark **rdd||123 stuff
rdd
inspark rdd stuff
would be surrounded:spark **rdd|| stuff
rdd
inspark rddrdd stuff
would not be surrounded:spark rddrdd stuff
rdd
inspark rdd123 stuff
would not be surrounded:spark rdd123 stuff