Add printAthenaCreateTable() support #28
Conversation
nsphung
changed the title
| def to_list_of_dictionaries(df): | ||
| return list(map(lambda r: r.asDict(), df.collect())) | ||
|
|
||
|
|
||
| def print_athena_create_table(df, athena_table_name, s3location): |
There was a problem hiding this comment.
shouldn't be easier to return a str and then allow the developer to print it or use it with any athena connector?
There was a problem hiding this comment.
I can but I was trying to stay connected with the Scala implementation in spark-daria def printAthenaCreateTable(df: DataFrame, athenaTableName: String, s3location: String): Unit
Should I change it ? If so, what kind of result/format string you expect ?
There was a problem hiding this comment.
Maybe we could have the athena_create_table that returns the str and then we keep the print_athena_create_table to stay connected with the scala implementation?
There was a problem hiding this comment.
@afranzi - I like that idea. I'll merge this in, but think the athena_create_table would be a good addition too!
|
@nsphung - thanks for the contribution! Keep them coming ;) |
Add printAthenaCreateTable() support #23
It's about the same as in spark-daria.