-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log("options.onrendered is deprecated, html2canvas returns a Promise containing the canvas"); #1610
Comments
Got a similar problem i made a website but didnt Uploaded it. When i try to make a screenshot the console said:"
but in jsfiddle everything works fine https://jsfiddle.net/699j050r/740/ |
is there any news about this issue, i got the same problem, ty. |
Well you have to rewrite it to use a Promise |
yet this bug is not resolved. I have updated html2canvas |
html2canvas returns a Promise with the canvas as the value |
the problem seems to be with addHTML not keeping up with html2canvas updates |
Is this already solved @ClaytonWang ? |
This means html2canvas doesn't use onrendered anymore, therefore this is not a bug. What you have to do now in order to execute code after rendering the canvas is the following:
|
We are closing this issue, because we will not support any longer Explaination: Best Regards |
@arasabbasi when do you think your new plugin will be ready? |
See #1176 |
Hi,
html2canvas :options.onrendered is deprecated. Bug,I found your code not update, so when call pdf.addHtml() funcion there will be an error occured.
The text was updated successfully, but these errors were encountered: