Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Barrel does not cancel item transactions when contains more 1 stack #1056

Closed
Ghostlyr opened this issue Aug 2, 2016 · 1 comment
Closed
Labels

Comments

@Ghostlyr
Copy link
Contributor

Ghostlyr commented Aug 2, 2016

Found out glitch with item barrel from PR:World. Item transactions out of him can't be canceled, when it filled more then 1 stack of item.

Vanilla example:
-1

I do not understand why it does not affect the first stack, but for some unknown reasons, It seems that when transaction is performes checking only to see whether the movable container is filled with the same item as in barrel.

In another case, if the slots are free, but the event should be canceled, the items themselves are not transferred, but the contents of the barrel is empties. The same happens in the case any other way to cancel the event interaction with the content, for example, bukkit events. This can be used for grief on servers.

Last version of PR.
MC 1.7.10 Forge 1614.

@MrTJP MrTJP added the outdated label Aug 3, 2017
@MrTJP
Copy link
Owner

MrTJP commented Aug 3, 2017

Barrels are slated to be removed so this is no longer an issue.

@MrTJP MrTJP closed this as completed Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants