Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication bug with Industrial Foregoing #1379

Closed
raltus opened this issue Aug 7, 2018 · 4 comments
Closed

Duplication bug with Industrial Foregoing #1379

raltus opened this issue Aug 7, 2018 · 4 comments

Comments

@raltus
Copy link

raltus commented Aug 7, 2018

ProjectRed-1.12.2-4.9.1.92-mechanical

I was doing some testing with the blackhole, blackhole controller and the transportation pipes. I noticed rapid duplication of the items in the controller. I am not sure which item is the the conflicting one so I'm posting this in both mods.

I recorded the interaction with the items in question.

https://youtu.be/Dqp_Xwn57hk

@Buuz135
Copy link

Buuz135 commented Aug 11, 2018

I will wait a bit on this, it might be on project red side, it works fine with other pipes. (I thought it was the issue in IF github, but I will try to replicate)

@covers1624
Copy link
Collaborator

Its entirely possible its PR's side, i don't have time to look into this right away, @Buuz135 pm me(discord) if you find anything in your digging / replication.

@Buuz135
Copy link

Buuz135 commented Aug 11, 2018

Could it be related that the capability returns stacks sizes bigger than 64 but you can only extract stacks with max stack size of 64?

@MrTJP
Copy link
Owner

MrTJP commented Oct 26, 2018

I can almost guarantee its because IF is breaking IItemHandler assumptions. I didn't get to look at it much but for one thing, I saw IF is ignoring the slot argument for inserting items and then taking care of distributing the item into its slots by itself. If it wants to do it this way, it should only present a single slot from the IItemHandler interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants