Discrepancy between Target Damage and System Damage Buttons

[XyrilP]

As title says, may be incompatible with the healing-received selector overall.

(Healing with Target Damage vs. without it (untargeted).)

[Aeristoka]

Have this exact same issue.

Original Application buttons have class="heal-damage vs. Target Damage buttons with class="pf2e-td heal-damage applied"

It's definitely something with how pf2e is interpreting the Target Damage healing application button.

[MrVauxs]

It's not about the classes. It's about having an outdated applyDamageFromMessage function.
Will have to copy paste the system code again so its up to date.

Made an issue in the pf2e system to not have to copy paste code and keep it from going stale.
foundryvtt/pf2e#10927

[Aeristoka]

It's not about the classes. It's about having an outdated applyDamageFromMessage function. Will have to copy paste the system code again so its up to date.

Made an issue in the pf2e system to not have to copy paste code and keep it from going stale. foundryvtt/pf2e#10927

Oh interesting, and a good ask of the pf2e devs!

[MrVauxs]

Looks like updating the damage function will need more involvement than a mere copy paste, as that doesn't seem to be doing much in terms of fixing these issues, if not outright breaking stuff.

If anyone wants to look into this, I will gladly merge the PR.

[SMJL88]

I'm not sure but would this be what is causing the life oracle curse to not apply the penalty properly properly? The system damage button works properly however the target one does not.

[MrVauxs]

I'm not sure but would this be what is causing the life oracle curse to not apply the penalty properly properly? The system damage button works properly however the target one does not.

Yes