Fixed the opening of the properties window for some users

CHANGELOG.md

@@ -1,9 +1,9 @@
 ## iGame VERSION_TAG - [RELEASE_DATE]
 ### Fixed
+- Fixed the opening of the properties window for some users, by reverting some changes from v2.4.1
 - Fixed the item (demo/game) renaming from the properties window
 - Fixed the addition of an item (demo/game) from the "Add game..." window. This was saved in a wrong way and was breaking the list
 
-## iGame 2.4.4 - [2023-09-11]
 ### Changed
 - Speedup the slavesListAddTail(), almost 200% faster. This has an impact on the slaves list creation during the scan and the loading from the file.
 

src/funcs.c

@@ -1279,8 +1279,9 @@ void repo_stop(void)
 // Shows the Properties window populating the information fields
 void slaveProperties(void)
 {
-	char *title;
-	if ((title = (char *)DoMethod(app->LV_GamesList, MUIM_NList_GetEntry, MUIV_NList_GetEntry_Active, NULL)) == NULL)
+	char *title = NULL;
+	DoMethod(app->LV_GamesList, MUIM_NList_GetEntry, MUIV_NList_GetEntry_Active, &title);
+	if(isStringEmpty(title))
 	{
 		msg_box((const char*)GetMBString(MSG_SelectGameFromList));
 		return;

src/strfuncs.c

@@ -304,6 +304,9 @@ STRPTR GetMBString(ULONG refId)
 
 BOOL isStringEmpty(const char *string)
 {
+	if (string == NULL)
+		return TRUE;
+
 	return string[0] == '\0';
 }