Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cake Teleportation Logic #16

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

ChampionAsh5357
Copy link
Contributor

Closes #1

Improves the teleportation logic when using a cake.

It checks the following to determine where to teleport. All locations check for a safe block underneath and that the bounding box of the entity is not in anything unable to spawn.

  1. Has the entity teleported from a cake in the other world? If so, spawn at that location.
  2. Loop through a sixteen block area from top to bottom to check for a safe position for the entity to spawn.
  3. Create a safe location at the position the entity is in.

Further work should look into better compatibility layers with other mods like #7. Though, honestly, that could use an entire rewrite to support basic datapack structuring and a custom plugin handler for more complex teleports.

Copy link
Owner

@Mrbysco Mrbysco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Mrbysco
Copy link
Owner

Mrbysco commented Oct 15, 2023

The only functionality that has changed is that the End cake no longer teleports you to the obsidian platform

@Mrbysco Mrbysco merged commit 77de040 into Mrbysco:1.20 Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nether Cake: Spawning in Lava SkyFactory4
2 participants