Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start_here: DUB postGenerateCommand assumes Windows #80

Closed
0xEAB opened this issue Mar 20, 2023 · 2 comments
Closed

start_here: DUB postGenerateCommand assumes Windows #80

0xEAB opened this issue Mar 20, 2023 · 2 comments

Comments

@0xEAB
Copy link

0xEAB commented Mar 20, 2023

The postGenerateCommand in the DUB recipe of the start_here project assumes that the user is running Windows (or any OS with backslash \ as its directory separator).

HipremeEngine/projects/start_here/dub.json

Line 51 in 40eeb64

"postGenerateCommands": ["cd ..\\..\\ && dub -c script -- .\\projects\\start_here"]

On other platforms building fails with /bin/sh: 1: cd: can't cd to .... or similar.
@0xEAB
Copy link
Author

0xEAB commented Mar 20, 2023 •
edited
Loading

A clean solution could be to make the script runner available as a dub package, so that the user would run dub run hipremeengine:script in the directory of their project. Please note that I don’t have enough understanding of the codebase to know whether this suggestion is actually reasonable or feasible.

@MrcSnm
Copy link
Owner

MrcSnm commented Mar 20, 2023

I'll starter by using postGenerateCommands-os then

@MrcSnm MrcSnm closed this as completed in 0a1c37e Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrcSnm @0xEAB