Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use "portable" PDB files (xamarin#758)
Context: https://github.com/dotnet/core/blob/79c19c12ab2bc11912551bb0c3025f602cd541d9/Documentation/diagnostics/portable_pdb.md In doing some performance testing with builds in VS 2019, I noticed: 115 ms _ConvertPdbFiles 1 calls And looking at files were converted: ConvertDebuggingFiles Parameters Files C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.pdb [Output] ConvertedFiles: C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.dll The Xamarin.Essentials NuGet package is shipping a non-portable PDB file. This is a Windows-specific format that Mono doesn't support. Xamarin.Android runs a tool called `pdb2mdb` when it encounters a non-portable PDB file so symbols be converted to something that Mono can use. If you have `DebugType=full` or `DebugType=pdbonly`, Xamarin.Android has to do this extra work to convert it. I see no drawbacks to just use `DebugType=portable` in this project all the time? Since Xamarin.Essentials uses sourcelink, I double-checked and they support portable PDBs: https://github.com/dotnet/sourcelink#prerequisites-for-net-projects I sent a similar PR to Xamarin.Forms, shipping since 3.4. I wrote a bit more detail on symbol files there if you need more info: xamarin/Xamarin.Forms#4201
- Loading branch information