check all prop types

Mrnikifabio · May 29, 2018 · 5412666 · 5412666
1 parent eb1fcb5
commit 5412666
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/browser/api/dialog.js b/lib/browser/api/dialog.js
@@ -176,15 +176,17 @@ module.exports = {
       throw new TypeError('Detail must be a string')
     }
     if (typeof checkboxLabel !== 'string') {
-      throw new TypeError('checkboxLabel must be a string')
+      throw new TypeError('Checkbox label must be a string')
     }
+    if (typeof checkboxChecked !== 'boolean') {
+      throw new TypeError('Checkbox checked value must be a boolean')
+    }
+    checkboxChecked = !!checkboxChecked
 
     if (normalizeAccessKeys) {
       buttons = buttons.map(normalizeAccessKey)
     }
 
-    checkboxChecked = !!checkboxChecked
-
     // Choose a default button to get selected when dialog is cancelled.
     if (cancelId == null) {
       cancelId = 0