-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Massive refactoring #2
Conversation
Refactored the original C/C++ version of GrailSort similar to my Java version. I'll be creating a new repository tomorrow for all versions of GrailSort.
Forgot to set Eclipse to "Spaces only", oops.
Thanks for the update with clear names and spacing. I've been maintaining a C++ fork of GrailSort and to be honest I never pretended to understand most of the algorithm; this will certainly help :) |
You're welcome! Would you like to help author a proper C++ fork of refactored GrailSort? I would really appreciate it. Your commits to WikiSort C++ look outstanding, and I certainly don't have the C++ experience that you do. |
Upon looking into it, the function makes no sense and no difference in its current implementation. Will look into it in the future.
I could surely make a proper C++ fork and repository for GrailSort if I find some time, sure. I would most likely rebase it on your cleanup if I do so. |
Thanks so much! I'll be making a whole Grail Sort repository with a C/C++, Java, and upcoming Python version. |
Oh, kind of like the WikiSort one? I don't know whether it drives adoption but at least you can make sure that every version benefits from general improvements. |
This version is now deprecated! |
This is a refactored version of Andrey Astrelin's Grail Sort with better spacing, clear and distinct variable names, and superfluous declarations and arguments removed. I also added a "GrailShift" function that acts like Insertion Sort when "GrailRotate" is dealing with lengths adjacent to each other. Hopefully, Grail Sort is more legible and easier to comprehend now.