Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020.1 Edition #17

Merged
merged 33 commits into from Jul 20, 2020
Merged

2020.1 Edition #17

merged 33 commits into from Jul 20, 2020

Conversation

Mte90
Copy link
Owner

@Mte90 Mte90 commented Mar 29, 2020

As title but is not yet ready, missing review.

@Ryuno-Ki
Copy link
Contributor

@Mte90 Ah, so it's basically what I reviewed earlier?

@Mte90
Copy link
Owner Author

Mte90 commented Mar 30, 2020

Yes this pr include what you found but also other stuff

Copy link
Contributor

@Ryuno-Ki Ryuno-Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there you have it: a review by me :-)

manuscript/appendix.md Outdated Show resolved Hide resolved
manuscript/appendix.md Outdated Show resolved Hide resolved
manuscript/preface.md Outdated Show resolved Hide resolved
manuscript/chapter5-what-you-can-do.md Outdated Show resolved Hide resolved
manuscript/chapter5-what-you-can-do.md Outdated Show resolved Hide resolved
manuscript/chapter2-philosophy.md Outdated Show resolved Hide resolved
manuscript/chapter2-philosophy.md Outdated Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
@Mte90
Copy link
Owner Author

Mte90 commented Mar 31, 2020

Thanks @Ryuno-Ki for the review but I didn't finish to add stuff in the book, I wanted just to start tracking them so i can more easily review.
So for you I suggest to do it when is ready because I didn't check the grammar etc yet (as you saw 😅).

@Ryuno-Ki
Copy link
Contributor

Sure. Ping me if you feel the need of another round of feedback :-)

@Mte90
Copy link
Owner Author

Mte90 commented May 29, 2020

I think that I am ready to release the new version but I will do a check of all those new changes before an official announcement for reviewing.

@Mte90
Copy link
Owner Author

Mte90 commented Jun 6, 2020

@Ryuno-Ki it is ready for the review :-)

manuscript/appendix-2.md Outdated Show resolved Hide resolved
manuscript/appendix-2.md Outdated Show resolved Hide resolved
manuscript/appendix-2.md Outdated Show resolved Hide resolved
manuscript/appendix-2.md Outdated Show resolved Hide resolved
manuscript/appendix-3.md Outdated Show resolved Hide resolved
manuscript/chapter2-philosophy.md Outdated Show resolved Hide resolved
manuscript/chapter2-philosophy.md Outdated Show resolved Hide resolved
manuscript/chapter2-philosophy.md Outdated Show resolved Hide resolved
manuscript/chapter2-philosophy.md Outdated Show resolved Hide resolved
manuscript/chapter2-philosophy.md Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
manuscript/chapter3-contributor-mode.md Outdated Show resolved Hide resolved
manuscript/chapter4-gotta-catch-em-all.md Outdated Show resolved Hide resolved
manuscript/chapter4-gotta-catch-em-all.md Outdated Show resolved Hide resolved
manuscript/chapter5-what-you-can-do.md Outdated Show resolved Hide resolved
manuscript/chapter6-find-time.md Outdated Show resolved Hide resolved
manuscript/chapter6-find-time.md Outdated Show resolved Hide resolved
manuscript/conclusion.md Outdated Show resolved Hide resolved
manuscript/conclusion.md Outdated Show resolved Hide resolved
manuscript/conclusion.md Outdated Show resolved Hide resolved
manuscript/conclusion.md Outdated Show resolved Hide resolved
manuscript/conclusion.md Show resolved Hide resolved
@Ryuno-Ki
Copy link
Contributor

I'm done looking at the remaining diffs.

Sorry for the delay, @Mte90!

@Mte90
Copy link
Owner Author

Mte90 commented Jul 18, 2020

Thanks for your time!
I think that there are just 2 questions to close/discuss and the book is ready!

@Ryuno-Ki
Copy link
Contributor

Hi Daniele!

So kind of GitHub to collapse all conversations. I hope, I spotted those questions.
Do you plan to give a release party? 🎊 :D

@Mte90
Copy link
Owner Author

Mte90 commented Jul 20, 2020

I don't think that I can do the party, but friday will be my 30 birthday so I think that can be a party anyway 😂

@Mte90 Mte90 merged commit c9153d1 into master Jul 20, 2020
@Mte90 Mte90 deleted the 2020.1 branch July 20, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants