-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why doesn't setforget work on unlimited chests? #74
Comments
You are confused about the difference between normal TreasureChest (which are indeed, like you said, also kindof unlimited) and Unlimited TreasureChest. It's semantics.
Maybe this will clarify:
I would say.. they are TreasureChests with a cooldown. You have a point, maybe "unlimited" is not the right word.
If I remember correctly, the message resets back to "You found a treasure!" when the forget-time has passed for that player. The message "You already found this treasure" is to indicate that the forget-time has not passed yet. Maybe im wrong? I forget.
I see you have a different idea for this plugin. There are many ways you can use this system. You use it in 1 particular way. The naming of the commands might be confusing. Maybe we could add more/better message. But this is how it works. Deal with it. |
You added a forget-time to the unlimited chest. |
I regret dismissing what you said so easily. I made these decisions about commands on a whim. It's because features have been added over time. You make a very good point at the least. I have to read what you said a couple more times. ... hmm we have 3 types of chests. In your words they are:
So you moved the setforget command to unlimited chests instead of regular. Hmm, this would have consequences for the message configuration. But that's not a good reason for my choice of names. Your view makes more sense! |
You've basically nailed what I meant. I'd just like to see an unlimited chest with a cool down, but there is absolutely nothing wrong with how it is. I mean everything I want can easily be accomplished right now. Thanks again. |
This plugin is really great, but some of the stuff just seems irrelevant. (Like multiple commands that do one thing.)
One thing I don't understand is why setforget doesn't work on unlimited chests. It kind of takes away from what this plugin is supposed to do.
Each chest can have a message set to it, and there are 3 types of messages.
Once you apply setforget to a chest the contents are going to regenerate after a set amount of time. So these chests are basically unlimited just not classified as unlimited.
However, since these chests aren't actually unlimited chests they have two messages applied to them. One for the first discovery and one for each discovery after that.
It isn't really necessary to say 'You found a treasure!' and then say 'You already found this treasure.' when the chest has reset and the entire point was to find it again.
Anyone wanting to set a message to their chests have to set two messages for a chest that is meant to act unlimited. It would be much more convenient for setforget to only work on unlimited chests. That way you just have to set one message.
This would give players two options. They can have unlimited chests that regenerate immediately or after time. Then they can have regular chests that give notice when found and all ready found and do all of the counting and keeping track of how many were found.
It just seems silly to say you've found treasure 6 out of 6 when it regenerates and there is more treasure. Unlimited should have setforget and regular chests shouldn't so they can work better with how the plugin is set up.
The text was updated successfully, but these errors were encountered: