Remove tracker position dependency, add wire/straw position info #125
Conversation
|
What is this PR waiting on? New digis? |
|
Once I fix the new conflicts it should be ready |
|
my understanding is this change requires new mcs files. As such it shouldn't be merged until those are available (after the re-digitization campaign). |
|
We now have significant samples of MDC2020 collections digitized with the data needed for these changes. Mixed samples are in preparation. Are we ready to merge this PR? In particular, are there any risks or warnings we need to give to users about how this affects their analysis of older collections? mcs.mu2e.CeEndpointOnSpillTriggered.MDC2020ae_best_v1_3.art |
|
We should be ready to merge. I've added instructions to https://mu2einternalwiki.fnal.gov/wiki/CalibrationSets for how to configure the database to run reco on v1_1 digi datasets and maintain consistent reconstruction and MC truth information. Older reco datasets will require using a previous TrkAna release. |
|
What warnings do we need to give to TrkAna users? Should we perhaps create
a TrkAna musing based on MDC2020ae? to make this more clear?
…On Thu, May 16, 2024 at 11:53 AM Richie Bonventre ***@***.***> wrote:
We should be ready to merge. I've added instructions to
https://mu2einternalwiki.fnal.gov/wiki/CalibrationSets for how to
configure the database to run reco on v1_1 digi datasets and maintain
consistent reconstruction and MC truth information. Older reco datasets
will require using a previous TrkAna release.
—
Reply to this email directly, view it on GitHub
<#125 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAH573KIB3SI5JPAN7HM3TZCT6DVAVCNFSM6AAAAABEAZKW62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVHE3TENZYGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
David Brown ***@***.***
Office Phone (510) 486-7261
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C) Berkeley, CA 94720
|
|
Richie and I just worked this out. data sets produced with v1_1 database
can only be read with older versions of code. To use the most recent
datasets produced with database version v1_3, the new codes must be used.
To fix this for TrkAna this PR needs to be merged and the result tagged (I
suggest v05_01_00). Andy, can you take care of that?
I will add a table to the MDC2020 web page describing which data
collections are compatible with which versions of code (Offline, TrkAna)
once that tag is out.
…On Thu, May 16, 2024 at 3:25 PM David Brown ***@***.***> wrote:
What warnings do we need to give to TrkAna users? Should we perhaps
create a TrkAna musing based on MDC2020ae? to make this more clear?
On Thu, May 16, 2024 at 11:53 AM Richie Bonventre <
***@***.***> wrote:
> We should be ready to merge. I've added instructions to
> https://mu2einternalwiki.fnal.gov/wiki/CalibrationSets for how to
> configure the database to run reco on v1_1 digi datasets and maintain
> consistent reconstruction and MC truth information. Older reco datasets
> will require using a previous TrkAna release.
>
> —
> Reply to this email directly, view it on GitHub
> <#125 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABAH573KIB3SI5JPAN7HM3TZCT6DVAVCNFSM6AAAAABEAZKW62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVHE3TENZYGE>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
David Brown ***@***.***
Office Phone (510) 486-7261
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C) Berkeley, CA 94720
--
David Brown ***@***.***
Office Phone (510) 486-7261
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C) Berkeley, CA 94720
|
|
Sorry, I missed this discussion (I will update my notifcation settings). I think we should tag the current head as v05_01_00 just in case anyone wants to run on the older datasets with any of the recent TrkAna updates (e.g. a working MakeClass). Then I will merge this PR and tag v05_02_00. I will also ask for the releases TrkAna v05_02_00 backing to MDC2020ae and TrkAna v05_01_00 backing to MDC2020ac (the same backing as v05_00_00) I will also note on the TrkAna wiki page which should be used with which |
requires Mu2e/Offline#1206