Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfortunate interaction between kOS, rover stability control, and wheel throttle #1572

Open
damerell opened this issue Jul 31, 2022 · 0 comments

Comments

@damerell
Copy link

damerell commented Jul 31, 2022

MechJebModuleRoverController.cs does:

if (s.wheelThrottle != 0 && (Math.Sign(s.wheelThrottle) + Math.Sign(curSpeed) != 0 || curSpeed < 1))
{
brake = false; // the AP or user want to drive into the direction of momentum so release the brake
}

kOS can produce a situation where what kOS calls "wheelthrottle" is 0 (and the wheels don't, in this situation, provide drive), what kOS calls "ship:control:pilotwheelthrottle" is non-zero (the pilot has the throttle non-zero), and the brakes are on. (This is in the context of a kOS script which brakes on overspeed regardless of what the human at the controls is doing).

MechJeb then immediately turns them off, which is not the desired behaviour.

I submit that a MechJeb option to turn this behaviour off would solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant