fix 1kN thruster suicide burn calc #902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'm not sure if real fuels changed its API so that this no longer works
correctly or if it was not correct in the first place -- but this
definitely gets minthrust/maxthrust very wrong for the 1kN thruster
in realism overhaul / real fuels.
also applied the thrust limiter w/o the ullage clipping to zero to the
max thrust, which is what i thought this problem was going to be in the
first place -- this still looks like more correct code here, but wasn't
the root of the bug i was seeing in the suicide calcs.