[Bug] got an error when generating font

[zhaihao]

the settings

and my font file:
MapleMonoSCNFNerdFont-Regular.ttf.zip

then I got an error:

An error occur: Traceback (most recent call last):
  File "<exec>", line 154, in processFont
  File "<exec>", line 157, in main
  File "/lib/python3.11/site-packages/fontTools/ttLib/ttFont.py", line 212, in save
    writer_reordersTables = self._save(tmp)
                            ^^^^^^^^^^^^^^^
  File "/lib/python3.11/site-packages/fontTools/ttLib/ttFont.py", line 259, in _save
    self._writeTable(tag, writer, done, tableCache)
  File "/lib/python3.11/site-packages/fontTools/ttLib/ttFont.py", line 711, in _writeTable
    tabledata = self.getTableData(tag)
                ^^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python3.11/site-packages/fontTools/ttLib/ttFont.py", line 733, in getTableData
    return self.tables[tag].compile(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python3.11/site-packages/fontTools/ttLib/tables/O_S_2f_2.py", line 161, in compile
    self.panose = sstruct.pack(panoseFormat, self.panose)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lib/python3.11/site-packages/fontTools/misc/sstruct.py", line 66, in pack
    obj = obj.__dict__
          ^^^^^^^^^^^^
AttributeError: 'str' object has no attribute '__dict__'

[MuTsunTsai]

It appears that MapleMono font in particular is not exactly created according to specs and could lead to various issues (such as #7) with font processing softwares. I could investigate into this when I have time, but likely this might not be an issue of FontFreeze.

[zhaihao]

@MuTsunTsai Thank you. I have solved this issue. You are right. The font file is patched by nerd-fonts.

so, freeze the font before applying the patch by nerd fonts can work very well

[MuTsunTsai]

@zhaihao Ah, that's good to know! I've added that remark in README.

[Finii]

Well, it seems an ancient version of the Nerd Fonts font-patcher is used by maple-font.
More importantly, and probably the reason for the bug, is to use a recent (i.e. Release 2023.01.01) fontforge together with the font-patcher. There have been various bugfixes in fontforge that resulted in broken tables.