Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudAutocomplete with IconSize has no effect #1496

Closed
Yomodo opened this issue May 4, 2021 · 5 comments
Closed

MudAutocomplete with IconSize has no effect #1496

Yomodo opened this issue May 4, 2021 · 5 comments
Labels
bug Something does not work as intended/expected fixed Fix has been merged
Milestone

Comments

@Yomodo
Copy link
Contributor

Yomodo commented May 4, 2021

Describe the bug
The IconSize has no effect when applied: <MudAutocomplete IconSize="Size.Large" ...>

Expected behavior
MudAutocomplete IconSize property should be applied correctly.

TryMudBlazor
https://try.mudblazor.com/snippet/GEmlYpYerTSwflLQ

Screenshots
image

@Yomodo Yomodo added the bug Something does not work as intended/expected label May 4, 2021
@ClumsyPenguin
Copy link
Contributor

ClumsyPenguin commented May 5, 2021

I would like to add a more in-depth explanation of why this does not work as intended...

From what i can see it applies an mud-icon-size-medium regardless of the applied IconSize property.

image

If you then just to experiment and change the font-size in the css itself it behaves correctly.
image

With that being said i hope i explained a little bit why and how it goes wrong. I think it just overrides the IconSize Property.

EDIT: This problem of css overriding the property that the developer gives it, is not limited to this case. I have the same problems with MudCharts in MudCards inside a MudGrid...

@Yomodo
Copy link
Contributor Author

Yomodo commented May 5, 2021

Similar to #1375

@mikes-gh
Copy link
Contributor

mikes-gh commented May 6, 2021

This is being fixed in #1494

@mikes-gh
Copy link
Contributor

mikes-gh commented May 6, 2021

I would like to add a more in-depth explanation of why this does not work as intended...

From what i can see it applies an mud-icon-size-medium regardless of the applied IconSize property.

image

If you then just to experiment and change the font-size in the css itself it behaves correctly.
image

With that being said i hope i explained a little bit why and how it goes wrong. I think it just overrides the IconSize Property.

EDIT: This problem of css overriding the property that the developer gives it, is not limited to this case. I have the same problems with MudCharts in MudCards inside a MudGrid...

The problem is not really the css directly. Its because we are hard coding the value of [Parameter] IconSize from AutoComplete's
inherited component. This is being fixed in the same way we fixed MudSelect.

@mikes-gh mikes-gh added the fixed Fix has been merged label May 10, 2021
@mikes-gh mikes-gh added this to the 5.0.9 milestone May 10, 2021
@slynch401k
Copy link

Seem to be having the same issue with MudNavGroup and MudNavLink. It always uses medium size. Dashboard and

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected fixed Fix has been merged
Projects
None yet
Development

No branches or pull requests

4 participants