Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MudAvatar: Outlined variants don't look right in darktheme #1987

Closed
JonBunator opened this issue Jun 24, 2021 · 5 comments · Fixed by #1990
Closed

MudAvatar: Outlined variants don't look right in darktheme #1987

JonBunator opened this issue Jun 24, 2021 · 5 comments · Fixed by #1990
Labels
triage Investigation required

Comments

@JonBunator
Copy link
Member

MudAvatars with Variant.Outlined look good in light mode:
grafik

But in dark mode the background color stays white:
grafik

Can you please take a look @boukenka ?
@JonBunator JonBunator added the triage Investigation required label Jun 24, 2021
@Garderoben
Copy link
Member

Its not just in Dark theme i noticed it yesterday as well it have lost its transparent background it seems?
image

JonBunator added a commit to JonBunator/MudBlazor that referenced this issue Jun 24, 2021
@JonBunator
MudAvatar: fixes background color for outlined variants (MudBlazor#1987)
8f956fb
@boukenka
Copy link
Contributor

@JonBunator Thank you for the fix and sorry for the inconvenience.

@JonBunator JonBunator mentioned this issue Jun 24, 2021
Merged
@JonBunator
Copy link
Member Author

@JonBunator Thank you for the fix and sorry for the inconvenience.

No worries. This was a very easy fix :)

@JonBunator
Copy link
Member Author

JonBunator commented Jun 24, 2021 •
edited

Its not just in Dark theme i noticed it yesterday as well it have lost its transparent background it seems?
image

@Garderoben
I don't think this is a bug. This is just how filled default avatars look:
grafik

If you want transparency just use Style="background-color:unset" on the avatar component.

@JonBunator
Copy link
Member Author

JonBunator commented Jun 24, 2021 •
edited

Maybe a Variant.Text would make sense: An avatar without an outline and transparent background. Right now Variant.Text does nothing

Garderoben pushed a commit that referenced this issue Jun 24, 2021
@JonBunator @Garderoben
MudAvatar: fixes background color for outlined variants (#1987)
a87968f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Investigation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MudAvatar: fixes background color for outlined variants (#1987) JonBunator/MudBlazor
3 participants
@Garderoben @boukenka @JonBunator