Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to MudBlazor 7.0.0-rc.2 and Latest Blazor Project Templates #465

Merged
merged 10 commits into from
Jun 24, 2024

Conversation

jperson2000
Copy link
Sponsor Contributor

@jperson2000 jperson2000 commented Jun 3, 2024

Description

Fixes: #451
Fixes: #466
Fixes: #467
Fixes: #458
Fixes: #450
Fixes: #455
Replaces PR: #452
Replaces PR: #459

This update upgrades the MudBlazor templates to use the latest Blazor .NET 8 templates and MudBlazor 7 RC 2. This update also uses the MudBlazor.Static library by @Anu6is to upgrade Account pages (which use Static rendering).

Interactive Auto (Dark Mode)

image

Interactive Auto (Light Mode)

image

Register

image

Login

image

Profile

image

Change Email

image

Change Password

image

Two-factor authentication

image

Personal Data

image

How Has This Been Tested?

This was tested by:

  1. Running .\InstallAndBuildAllTemplates.ps1 PowerShell script
  2. Observing that all builds succeeded
  3. Opening each solution and testing all links

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@jperson2000 jperson2000 changed the title Templates: Upgraded to MudBlazor 7 and Latest Blazor Project Templates Templates: Upgraded to MudBlazor 7.0.0-preview.4 and Latest Blazor Project Templates Jun 3, 2024
@jperson2000
Copy link
Sponsor Contributor Author

@ScarletKuro @henon @danielchalmers @mikes-gh Here's a PR for the .NET 8 MudBlazor 7.0.0-preview.4 templates. (I had to start over.) Currently, the template has the basic pages updated and the test PS script works, but I had some questions about what else you'd like to see:

  1. Do you want all of the auth pages (about 20 of them) upgraded to MudBlazor components?
  2. The template has something which may feel like a bug to end users. The Microsoft Identity code has options.SignIn.RequireConfirmedAccount = true in it, which means nobody who registers an account can immediately log in until they connect to the database and manually modify their record. I would like to change this flag to false to fix this (and it works), but it's less secure. Are you okay with this change?
  3. The Home.razor page in the template has one set of instructions for all project types. Shall we make this more dynamic to show different messages per project type? (I would vote yes)

@jperson2000 jperson2000 marked this pull request as ready for review June 3, 2024 04:08
@jperson2000 jperson2000 changed the title Templates: Upgraded to MudBlazor 7.0.0-preview.4 and Latest Blazor Project Templates Upgraded to MudBlazor 7.0.0-preview.4 and Latest Blazor Project Templates Jun 3, 2024
@henon henon changed the title Upgraded to MudBlazor 7.0.0-preview.4 and Latest Blazor Project Templates Upgrad to MudBlazor 7.0.0-preview.4 and Latest Blazor Project Templates Jun 3, 2024
@henon henon changed the title Upgrad to MudBlazor 7.0.0-preview.4 and Latest Blazor Project Templates Upgrade to MudBlazor 7.0.0-preview.4 and Latest Blazor Project Templates Jun 3, 2024
@ScarletKuro
Copy link
Member

ScarletKuro commented Jun 21, 2024

Global Mode without Auth:

Mode Status
Auto Working
Wasm Working
Server Working

Per page without Auth:

Mode Status Description
Auto Working -
Wasm Working -
Server Working -

I didn't check the static SSR yet (auth). I think we need to fix the per page first to move on the next step.

@ScarletKuro
Copy link
Member

ScarletKuro commented Jun 21, 2024

Can we control the default selection mode?
I would want it to be global -> wasm.
That would eliminate a lot of complaints/issues, as many newbie people just hit the next button.

@jperson2000
Copy link
Sponsor Contributor Author

Can we control the default selection mode? I would want it to be global -> wasm. That would eliminate a lot of complaints/issues, as many newbie people just hit the next button.

Yes, I was able to change the defaults in template.json, in the InteractivityPlatform and InteractivityLocation sections.

@jperson2000
Copy link
Sponsor Contributor Author

Per page without Auth: Auto/Wasm Not Working

Thanks @ScarletKuro , I have fixed these issues and have retested all templates. Also:

  • The Dark/Light Mode button only appears for apps without Auth
  • The default template is now WebAssembly/Global
  • The bootstrap.css and app.css are now only included by App.razor while viewing Auth pages.

... the only issue I couldn't figure out is regarding app.css and Auth pages. The CSS shows underlines for links in the Nav Panel, but the non-Auth pages look okay:

image

@ScarletKuro
Copy link
Member

ScarletKuro commented Jun 22, 2024

Ah, I just noticed it's for v6 :( I don't think it's compatible with v7, there is v7 branch but no nuget

@Anu6is
Copy link

Anu6is commented Jun 22, 2024

Pushed a pre-release for v7.
Think I thought v7 was getting released early June so I intended to wait.

@jperson2000
Copy link
Sponsor Contributor Author

Pushed a pre-release for v7. Think I thought v7 was getting released early June so I intended to wait.

Ok, thanks @Anu6is! I'm excited to check out your library and will work on the Auth pages tonight.

@jperson2000 jperson2000 changed the title Upgrade to MudBlazor 7.0.0-preview.4 and Latest Blazor Project Templates Upgrade to MudBlazor 7.0.0-rc.2 and Latest Blazor Project Templates Jun 23, 2024
@jperson2000 jperson2000 self-assigned this Jun 23, 2024
@jperson2000 jperson2000 requested a review from Anu6is June 23, 2024 05:35
@jperson2000
Copy link
Sponsor Contributor Author

@Anu6is your library worked beautifully for upgrading the Account pages. Thanks so much for your work on the static form components!

@ScarletKuro
Copy link
Member

Everything seems to work. It's a very great work.

@ScarletKuro
Copy link
Member

Is anyone willing to double check the templates itself? @henon @mikes-gh @xC0dex @Anu6is @danielchalmers
Otherwise I want to merge this ASAP.

@xC0dex
Copy link
Member

xC0dex commented Jun 23, 2024

Is anyone willing to double check the templates itself? @henon @mikes-gh @xC0dex @Anu6is @danielchalmers Otherwise I want to merge this ASAP.

I could try it out this evening, so in about 2–3 hours 👍

Copy link
Member

@xC0dex xC0dex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created some solutions with these templates in Rider and it looks good 👍

@henon henon merged commit 5cd2b40 into MudBlazor:dev Jun 24, 2024
2 checks passed
@henon
Copy link
Collaborator

henon commented Jun 24, 2024

Thank you very much

@jperson2000 jperson2000 deleted the feature/mudblazor7 branch June 24, 2024 14:14
@jperson2000
Copy link
Sponsor Contributor Author

Just a quick note: When MudBlazor 7.0.0 is released, a small PR will be needed to change the Package Reference version to 7.* for templates.

@ScarletKuro
Copy link
Member

ScarletKuro commented Jun 24, 2024

Just a quick note: When MudBlazor 7.0.0 is released, a small PR will be needed to change the Package Reference version to 7.* for templates.

Yes, and MudBlazor.Static probably too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants