Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable icon option has no text #482

Closed
vadi2 opened this issue Mar 31, 2017 · 2 comments
Closed

disable icon option has no text #482

vadi2 opened this issue Mar 31, 2017 · 2 comments
Assignees
Labels

Comments

@vadi2
Copy link
Member

vadi2 commented Mar 31, 2017

Right-clicking the icon bar will display a checkmark, without any identifying text.

Ubuntu Karmic, Mudlet 1.0.5.1

Launchpad Details: #LP501504 Elias Roa - 2009-12-30 00:44:14 +0000

@vadi2 vadi2 added the medium label Mar 31, 2017
@vadi2
Copy link
Member Author

vadi2 commented Mar 31, 2017

This is because we haven't consistently been using setWindowTitle() on: Main Dockable/Hideable Toolbars (one on main window, two on editor) user windows/miniconsole, mappers etc. All of them will appear on the context menu for tool-bars and other elements and some of them (like the main tool bar can be hidden/shown - the ones that can't - the user tool-bars or top level "button groups" are grayed out but still show a filled in checkbox if they are visible or a cleared one if they are disabled and thus hidden).

As a matter of policy I think it is essential to fill out this data so we don't get this confusing artifact - after all, if the user has hidden the menu bar and accidentally clicks the checkbox to hide the main tool bar they might have to kill the program and restart it to allow the recovery code to give them the access to the profile preferences dialog where this can also be controlled. Or we need to add a "show main toolbar" menu option to the main console window that currently offers the "copy" and "copy to HTML" actions as context menu actions...

Launchpad Details: #LPC Stephen Lyons - 2015-09-27 20:11:21 +0000

@SlySven SlySven self-assigned this Apr 1, 2017
@vadi2
Copy link
Member Author

vadi2 commented Sep 1, 2018

This is fixed now.

@vadi2 vadi2 closed this as completed Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants