expandAlias("command", nil) should not error

[vadi2]

expandAlias("x", nil) currently gives this error: <Send: wrong argument type>

expandAlias("x", nil) should be treated the same as expandAlias("x")

Launchpad Details: #LP1456794 Vadim Peretokin - 2015-05-19 20:37:49 +0000

[vadi2]

This Lua sub-system command is mapped to TLuaInterpreter::Send(...) and the second argument, if specified, is a boolean that is recorded as wantPrint (and defaults to TRUE if NOT specified) and then dispatched to the Host class instance with:

pHost->send( QString( luaSendText.c_str() ), wantPrint, false );

Given that boolean FALSE seems to be largely inter-changeable with NIL I don't see how expandAlias("x", nil) can be treated as expandAlias("x") when the latter is already coded as expandAlias("x", true) and NOT expandAlias("x", false)...

I suspect this will become a WON'T FIX or it will break existing code won't it?

Fair enough, the error messages are not up to scratch for this function, but sadly that is not uncommon!

Launchpad Details: #LPC Stephen Lyons - 2015-05-20 22:18:06 +0000

[vadi2]

expandAlias("x", nil) and expandAlias("x") are exactly the same as far as Lua code is concerned.

Launchpad Details: #LPC Vadim Peretokin - 2017-03-31 19:16:53 +0000