login failure (and non-helpful error!) on latest development build

[erikarn]

Brief summary of issue / Description of requested feature:

A freshly built development (ced5f71) mudlet, trying to log into achaea with a completely blank profile, just gave a socket disconnect error upon connecting and getting to the login prompt.

Steps to reproduce the issue / Reasons for adding feature:

1. Fresh built mudlet, no profile
2. Click on "achaea" and then "connect"
3. See error

Error output / Expected result of feature

With MCCPv2 on:

(... achaea stuff)
Enter an option or enter your character's name. 
    
[ ALERT ] - Socket got disconnected.
            Reason: The remote host closed the connection
[ INFO ]  - Connection time: 00:00:00.415

With MCCPv2 compression off:

Enter an option or enter your character's name. 
[ WARN ]  - Could not log in to the game: Wrong name or password.
    
[ ALERT ] - Socket got disconnected.
            Reason: User Disconnected
[ INFO ]  - Connection time: 00:00:00.337

If I add user/pass to the profile info and click connect, then everything works A-OK.

If I disable GMCP entirely and connect, then things work fine, I login with user/pass in the telnet stream like normal.

Extra information, such as the Mudlet version, operating system and ideas for how to solve / implement:

[mpconley]

I recommend closing this issue as it is an Achaea issue. They have implemented Char.Login authentication but have not accounted for the case where credentials are not being sent from Mudlet. It works fine if the character name and password are inside of the latest PTB build, but closes connection when they are not there.

[SlySven]

@mpconley You mean it is a "it's not me, it is you" situation? 😀

[mfontani]

From the spec:

In case the client does not know both the character name and password, it may notify the server of this by sending an empty response. This can be used a response to any authentication method:
Char.Login.Credentials {}

Looks like they're not handling that gracefully.

If a server receives that Char.Login.Credentials {} it SHOULD basically ignore it (or tell the user that the system would have supported auto-login, but the client hasn't configured it), and not attempt to log in with an empty username/password.