Reachability check on init

[DerAndereAndi]

If I am reading the source correctly, you are checking for reachability in the init method on the main thread: https://github.com/MugunthKumar/MKNetworkKit/blob/master/MKNetworkKit/MKNetworkEngine.m#L93

This should not be done, since it might lock up the application if there is no or hardly network available, and cause the app to be killed by the watchdog.

As Apple reminded lots of times in its sessions in all past WWDCs, reachability should only be used after a connection failed and not before connecting. Also it should never be done in the main thread on startup.

P.S.: I saw other developers doing this and having loads of problems, including crashes on startup, due to the watchdog coming up.

[jomnius]

(just supporting this important design issue, so that it won't be forgotten)

[adamransom]

+1 for not forgetting about this

[MugunthKumar]

Closed as fixed