This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
check if configuration macroses already defined #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before settings default values
|
@MugunthKumar I also think that using a prefix in these settings names will be a good practice... I can add |
|
And here is a simple empty project with added MKStoreKit as a cocoapod and with demo of this config redefining feature. |
MugunthKumar
pushed a commit
that referenced
this pull request
Nov 27, 2012
check if configuration macroses already defined
acrist
pushed a commit
to Coppertino/MKStoreKit
that referenced
this pull request
Jul 10, 2013
check if configuration macroses already defined
acrist
pushed a commit
to Coppertino/MKStoreKit
that referenced
this pull request
Jul 10, 2013
check if configuration macroses already defined
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will allow users to define these settings outside the files which included in the MKStoreKit library. It especially makes sense for cocoapods installations.
In cocoapods installations these file will be added in Pods project and we don't have to edit it manually. It will be regenerated and edit only by cocoapods.
And with this commit it becomes possible to define such macroses before importing MKStoreKit's headers.