Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading/Saving #5

Open
Muirrum opened this issue Oct 8, 2019 · 13 comments
Open

Loading/Saving #5

Muirrum opened this issue Oct 8, 2019 · 13 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@Muirrum
Copy link
Owner

Muirrum commented Oct 8, 2019

Implement a way for the game to be saved via SQLite/JSON, whichever is easier for you. Bonus points for making a way to swap between them (Maybe a SaveProvider base class and then SQLiteSaveProvider/JSONSaveProvider would be best)

@Muirrum Muirrum added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Oct 8, 2019
@nurettn
Copy link

nurettn commented Oct 8, 2019

I will give a try with Json, can you assign me to this?

@Muirrum
Copy link
Owner Author

Muirrum commented Oct 16, 2019

@nurettinabaci What's the progress on this?

@nurettn
Copy link

nurettn commented Oct 16, 2019

I couldn't spare time exactly, you can unassign me if you want

@Muirrum Muirrum added this to the Persistent World milestone Oct 17, 2019
@JessieVela
Copy link
Contributor

I have experience with SQLite but not with JSON. I can give it a try and see if I can do both.

@Muirrum
Copy link
Owner Author

Muirrum commented Oct 17, 2019

Alright! Make sure to define a base SaveProvider class or similar so users can define their own.

@JessieVela
Copy link
Contributor

When you say users, are you meaning the actual players?

@Muirrum
Copy link
Owner Author

Muirrum commented Oct 18, 2019

I'm meaning the people using the library

@JessieVela
Copy link
Contributor

What are the main things that will be saved? Currently, I see Person will be saved and possibly in the future Locations.

@Muirrum
Copy link
Owner Author

Muirrum commented Oct 18, 2019

@JessieVela The Player object should be saved, as well as the state of any Mobiles in the game. That's all I can think of right now.

@JessieVela
Copy link
Contributor

Currently, we are not creating Mobiles? its not implemented yet?

@Muirrum
Copy link
Owner Author

Muirrum commented Oct 23, 2019

I mean, you can define new ones and add them to areas, but nothing displays them yet.

@JessieVela
Copy link
Contributor

Thats what I meant nothing displays them yet. To prevent scope creep im going to only add the player into the database. In the future the save will just need to be expanded to accommodate mobiles added to the game. Also, if its okay I would like to do this in parts. One pull request for SQLite and then another for JSON.

@Muirrum
Copy link
Owner Author

Muirrum commented Oct 24, 2019

That's fine, as long as there's a way to define new ones (base class)

@JessieVela JessieVela removed their assignment Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants