Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CommandManager): Class to manage all commands #7

Closed
wants to merge 4 commits into from
Closed

feat(CommandManager): Class to manage all commands #7

wants to merge 4 commits into from

Conversation

EikeSan
Copy link
Contributor

@EikeSan EikeSan commented Oct 9, 2019 •
edited

I change a few things... :D
The annotation is better using to a class, because the single resposability recommedation, so each class should do only one behaivor.
And with this all Command class should have the CommandAnnotanion and implements the Interface Command.
If you have any tips or review mention me ;)

#2

@EikeSan EikeSan mentioned this pull request Oct 9, 2019
Closed
Muirrum
Muirrum requested changes Oct 9, 2019
View reviewed changes
Copy link
Owner

@Muirrum Muirrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general, beyond my comments, the added CommandManager class and associated classes just need documentation. Once that's added it should be good to merge.

pom.xml Show resolved Hide resolved
Muirrum
Muirrum approved these changes Oct 10, 2019
View reviewed changes
Copy link
Owner

@Muirrum Muirrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/main/java/xyz/devosmium/games/textadventureengine/commands/Attack.java Show resolved Hide resolved
src/main/java/xyz/devosmium/games/textadventureengine/commands/Exit.java Show resolved Hide resolved
src/main/java/xyz/devosmium/games/textadventureengine/commands/CommandAnnotation.java Show resolved Hide resolved
@Muirrum
Copy link
Owner

Muirrum commented Oct 10, 2019

Can you re-create this pull request to the develop branch?

@Muirrum Muirrum closed this Oct 10, 2019
@Muirrum Muirrum added the invalid This doesn't seem right label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Muirrum Muirrum Muirrum approved these changes

Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EikeSan @Muirrum