Skip to content

Commit

Permalink
Artifact + Matrix - 8
Browse files Browse the repository at this point in the history
For public-dash, admin-dash where ARGS are now being used, need to add the args under build command in the docker compose files.
Gives error if arg is at the same hierarchical level as build.

Also, public-dash docker-compose.yml (non-dev) version changed to have build: context, dockerfile ; unlike only build: frontend.
This allows adding args under build. Similar to how currently being built in docker-compose.dev.yml.

Also, args to be added under notebook-server and not dashboard since viz_scripts builds off of server image and not frontend, which is a node image.
  • Loading branch information
Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed May 2, 2024
1 parent 15c9da1 commit 0c78ad3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions docker-compose-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ services:
build:
context: .
dockerfile: docker/Dockerfile
args:
DOCKER_IMAGE_TAG: ''
args:
DOCKER_IMAGE_TAG: ''
image: e-mission/opdash:0.0.1
ports:
- "8050:8050"
Expand Down
4 changes: 2 additions & 2 deletions docker-compose-prod-nginx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ services:
build:
context: .
dockerfile: docker/Dockerfile
args:
DOCKER_IMAGE_TAG: ''
args:
DOCKER_IMAGE_TAG: ''
image: e-mission/opdash:0.0.1
environment:
DASH_DEBUG_MODE: "True"
Expand Down
4 changes: 2 additions & 2 deletions docker-compose-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ services:
build:
context: .
dockerfile: docker/Dockerfile
args:
DOCKER_IMAGE_TAG: ''
args:
DOCKER_IMAGE_TAG: ''
image: e-mission/opdash:0.0.1
ports:
- "8050:8050"
Expand Down

0 comments on commit 0c78ad3

Please sign in to comment.