Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch loading/application exceptions escape from MinecraftProfile and *ProfileStrategy #1015

Closed
peterix opened this issue May 29, 2015 · 2 comments
Closed

Patch loading/application exceptions escape from MinecraftProfile and *ProfileStrategy #1015

peterix opened this issue May 29, 2015 · 2 comments
Assignees
@peterix
Labels
bug
Milestone
0.4.7

Comments

@peterix
Copy link
Member

peterix commented May 29, 2015

Adding jar mods should trigger version update, just like customize/revert now do.
@peterix peterix added this to the 0.4.7 milestone May 29, 2015
@peterix peterix self-assigned this May 29, 2015
peterix added a commit that referenced this issue May 29, 2015
@peterix
GH-1015 fix crash when version is incomplete and adding jar mods
84757f4
@peterix
Copy link
Member Author

peterix commented May 29, 2015

The issue is unhandled exceptions escaping from MinecraftProfile

The actual solution is to fix this patch loading mess and make the loading errors more granular - catch them at the patch level. Ideally show the problem in the UI.

@peterix peterix changed the title Adding jar mods while the Minecraft version isn't complete causes a crash Patch loading/appolication exceptions escape from MinecraftProfile and *ProfileStrategy May 29, 2015
@peterix peterix changed the title Patch loading/appolication exceptions escape from MinecraftProfile and *ProfileStrategy Patch loading/application exceptions escape from MinecraftProfile and *ProfileStrategy May 29, 2015
@peterix peterix added ready and removed in progress labels May 31, 2015
peterix added a commit that referenced this issue May 31, 2015
@peterix
GH-1015 catch exceptions when doing profile reapply
99f248e 
This is a temporary solution.
@peterix
Copy link
Member Author

peterix commented May 31, 2015

With the current changes, incomplete/errored versions will still break the profile, but won't show up intelligently in the UI.

Mission accomplished for now.

See #1029 for continuation.

@peterix peterix closed this as completed May 31, 2015
@Brunnosh Brunnosh mentioned this issue Jul 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterix peterix

Labels
bug
Projects
None yet
Milestone
0.4.7
Development

No branches or pull requests
1 participant
@peterix