Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continues to ask for offline mode username after reconnecting to the internet #5166

Open
1 task done
Lamby777 opened this issue May 28, 2023 · 0 comments
Open
1 task done
Labels
Auth MSA and Mojang auth related issues bug

Comments

@Lamby777
Copy link

Operating System

Windows

Description of bug

So, when you're offline, and you try to play, it'll automatically try to launch in Offline Mode, so it asks for your username, right? If you just realized then that you didn't have internet, and you back out of the menu and try again after connecting, it still asks for your offline mode name. This might seem kinda like an edge case, but it happened to me for something like the 5th time today, so I might as well report it.

Not sure if this is too similar to #4356, but that one's mostly focused on sleep rather than not having connection altogether, so yea.

Steps to reproduce

  1. Disconnect from the internet
  2. Open MultiMC
  3. Launch an instance
  4. X out of the popup asking for your offline mode username
  5. Connect to internet (don't close MultiMC)
  6. Launch the instance again
    (shows same popup)

Suspected cause

Haven't looked at the code, but I'd assume it's checking for internet when you open up MultiMC, and then just remembers that you don't have internet as long as that process is open? Maybe check for internet at launch-time? idk

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@Lamby777 Lamby777 added the bug label May 28, 2023
@phit phit added the Auth MSA and Mojang auth related issues label Jul 16, 2023
SithumDissanayake added a commit to SithumDissanayake/Launcher that referenced this issue Oct 21, 2023
In the login function of LaunchController, added requestRefresh on the current m_accountToUse.
This allows the accountState of accountToUse to be updated before running through what login is meant to depending on the accountState. This is to allow for the cases where a device might be back online after launching the Launcher. Putting this in the tryagain while loop also allows to check if a users account is expired during the login process.
SithumDissanayake added a commit to SithumDissanayake/Launcher that referenced this issue Oct 21, 2023
In the login function of LaunchController, added requestRefresh on the current m_accountToUse.
This allows the accountState of accountToUse to be updated before running through what login is meant to depending on the accountState. This is to allow for the cases where a device might be back online after launching the Launcher. Putting this in the tryagain while loop also allows to check if a users account is expired during the login process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auth MSA and Mojang auth related issues bug
Projects
None yet
Development

No branches or pull requests

2 participants