Cryptonight rework

[UselessGuru]

Please test - I cannot test myself at the moment!!!

This PR enables all 4 cryptonight algorithms

This whole monero / Cryptonight fork is a mess! See here:
xmrig/xmrig#482

There are now 4 different cryptonight algorithms:
Cryptonight (old)
CryptonightLite
CryptonightHeavy
CryptonightV7
And it all depends on the coin name. Grr...

Only two MPM supported pools allow mining cryptonight: Nicehash & MPH/MPHC

Currently only NiceHash properly list CryptonightV7 as new algorithm.
MPH / MPHC send inconsistent data through the API which differs from what it says on the web page.

[unikon2450]

Hello. I changed the files but something is not working properly. Can you check what I did wrong?

MultiPoolMiner_2018-04-12_11-02-17.txt

[station384]

The change to cryptonightv7 seems to be working on nicehash.
Both algorithms appear and execute as unique items.

I to am getting the same error as reported by @unikon2450 it looks like some part of the code cant find a property. It looks like its parsing the '-' in cryptonight-lite as a parameter.

[UselessGuru]

@station384 & @unikon2450

Thank you for your valuable feedback!

I've made some changes which hopefully fix the reported issue. Please try again and report back. TIA!

[unikon2450]

I still have a problem with MPH. MPM does not work on this pool. MPM does not even begin to test miners in cryptonight.
I also used the default start file. Cryptonight is benchmarked only on nicehash.
MPH start.bat MultiPoolMiner_2018-04-12_18-05-17.txt
start.bat MultiPoolMiner_2018-04-12_18-14-18.txt

[station384]

@UselessGuru So far I have not been getting the error that it can't find file that @unikon2450 mentioned when mining nicehash, I have all the tests of Claymore going, and they have all passed and appear to work correctly.

I can confirm @unikon2450 that MPM is not even testing benchmarks for cryptonight on MultiPoolHub. It appears it isn't matching that it is an option on that pool.

[station384]

@UselessGuru it appears changing the -eq to -Like so it will take advantage of the wildcard was the intent of the change.
Correction: (since I can't send a pull request to your pull request :/ )
File MiningPoolHub.ps1 line 37:40 change -eq to -Like
File MiningPoolHubCoins.ps1 line 37:45 change -eq to -Like

[grantemsley]

Thanks @station384 - looks like you are correct, I've made those changes and the algorithms show up now.

Seeing a lot of failed connection issues on the miners though - not sure if pool issues or it's not setting the pool parameters properly.

[symalla]

It looks like the miners are trying to use the URL of us-east.hub.miningpoolhub.com:20580 instead of us-east.cryptonight-hub.miningpoolhub.com:20580

[UselessGuru]

@symalla

MPH / MPHC send inconsistent data through API for cryptonight / monero...
API says: 'host: hub.miningpoolhub.com'
Web page says: [location].cryptonight-hub.miningpoolhub.com

I fixed the pool files accordingly - see if it works... :-)

[angelics]

i think u forgot about "monero7" for xmr-stak.

[UselessGuru]

i think u forgot about "monero7" for xmr-stak.

Why?
currency = "$_"
is in all 3 miner files, where $_ stands for one of the 3 supported (newly added) algorithms cryptonightV7, cryptonight-lite & cryptonight-heavy.

According to documentation this should be sufficient:

If your prefered coin is not listed, you can chose one of the following algorithms:
Cryptonight - 2 MiB scratchpad memory
Cryptonight-light - 1 MiB scratchpad memory
Please note, this list is not complete, and is not an endorsement.

Does it not work? Note that not all pools expose the coin/currency name :(

[n3cr0cr0w]

US should be us-east.cryptonight-hub.miningpoolhub.com:20580 and not us.cryptonight-hub.miningpoolhub.com.

https://monero.miningpoolhub.com/

[HaTaX2]

I had to change FireiceCpu.ps1 to reflect what MPH is looking for in the currency / coin field (Without this change MPH kept rejecting submissions from xmr-stak) :
currency = "monero7"

Additionally I modified Miningpoolhub.ps1 to reflect the host properly:
Host = "us-east.cryptonight-$($MiningPoolHub_Hosts | Sort-Object

I'm aware that this is a hard coded fix and isn't ideal, it was late at night and I just wanted to get it working before I went to bed. Seemed to work well and it continued to mine as expected all evening.

Here's some of the log shown by xmr-stak.exe onscreen with those changes (I took out lines that weren't relevant) :

[2018-04-13 14:16:19] : Mining coin: monero7
[2018-04-13 14:16:19] : Fast-connecting to us-east.cryptonight-hub.miningpoolhub.com:17024 pool ...
[2018-04-13 14:16:19] : Pool us-east.cryptonight-hub.miningpoolhub.com:17024 connected. Logging in...
[2018-04-13 14:16:20] : Difficulty changed. Now: 500054.
[2018-04-13 14:16:20] : Pool logged in.
[2018-04-13 14:16:20] : New block detected.
[2018-04-13 14:16:21] : Difficulty changed. Now: 40000.
[2018-04-13 14:16:21] : New block detected.
[2018-04-13 14:16:34] : New block detected.
[2018-04-13 14:16:37] : Result accepted by the pool.
[2018-04-13 14:16:38] : Result accepted by the pool.
[2018-04-13 14:16:41] : New block detected.

[UselessGuru]

Yet another try fixing the cryptonight mess :)

currency = "monero7"

Fixed. For Fireice (Xmr-Stak) currency (e.g. monero7) will be set if pool sends coin by API. If no coin name is available through API the algorithm will be used instead (e.g. currency = "cryptonight-light").

Host = "us-east.cryptonight-$($MiningPoolHub_Hosts

Fixed. Changed MPH / MPHC url for cryptonight

I am interested how (if???) cryptonight mining is working on nicehash - nicehash lists cryptonight AND cryptonight7 as available algorithms, but does not say what currency they are mining with.
??? How should that work when Xmr-Stak requires the correct currency to be specified ???

[angelics]

based on algorithm.txt and past ccminer "algo" , (eg. poly, polytimos)
isnt it much "proper" way to have monero7 in algorithm.txt rather than having it to convert inside miner.ps1?

[aaronsta1]

seems to work but after awhile pwsh.exe takes 100% system memory.. didnt do it on the main branch.

[erwan-joly]

this doesn't seems to work. My vega 64 are a lot better for cryptonight v7 and the benchmark select ETH+pasc

[UselessGuru]

@angelics

based on algorithm.txt and past ccminer "algo" , (eg. poly, polytimos)
isnt it much "proper" way to have monero7 in algorithm.txt rather than having it to convert inside miner.ps1?

I cannot think of one. That cryptonight stuff is a total mess... I am not happy with where we are now :-(

[angelics]

@UselessGuru
FireiceNvidia242.zip

i added algo into algorigthm.txt. and do not have include.ps1 as urs here.
last time i checked it works,as an nvidia user i don particularly mine xmr or xmr pool.
since there is no recommended pools (mph,zpool) support any other coin than monerov7, shudnt we just leave other coins out atm? pool operators and miner dev messed up with the names atm.

[grantemsley]

I'm testing this. Not done yet, but have some questions/comments already:

• Is miningpoolhub the only pool we have that supports cryptonight algorithms? I think nicehash supports it too don't they?
• MiningPoolHubCoins API reports 2 coins that use Cryptonight-Monero (their name for CryptonightV7): Monero and Electroneum. But isn't Electroneum still on the regular old Cryptonight? Everything I can find says it is. Is their API wrong? Is that pool even working???
• I'd recommend ditching the Get-CryptonightAlgorithm function and do the conversions from pool name to real algorithm name in the pool files. Each pool seems to be handling it differently and its probably safer to tackle each pool one by one.
• Between the pools and the miner authors nobody came up with a single naming convention for this stuff? Why? What is wrong with people!

[mkirov0]

KlausT has a Cryptonight only miner out. Posting just FYI.
https://github.com/KlausT/ccminer-cryptonight

[grantemsley]

Tested, it works. Ready to merge.

[grantemsley]

I've been able to confirm that all of the updated miners are working properly with the new algorithms and reporting successful shares to the pool - Cast, ClaymoreAmd, ClaymoreCpu, FireiceNvidia, FireiceAmd, FireiceCpu, XMrigAmd, and XMrigNvidia all work perfectly for me. Prospector crashes and doesn't seem to like my hardware very much, but does get a valid configuration and seem to work.

Both MiningPoolHub and Nicehash work fine. Those seem to be the only pools that support CryptoNightV7.

There are probably other miners that have added support for CryptoNightV7, but they can be added later in a separate PR.