Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop official support for Python 3.7 #2039

Closed
ewels opened this issue Sep 14, 2023 · 3 comments · Fixed by #2147
Closed

Drop official support for Python 3.7 #2039

ewels opened this issue Sep 14, 2023 · 3 comments · Fixed by #2147
Labels
core: infrastructure Something to do with the MultiQC infra

Comments

@ewels
Copy link
Member

ewels commented Sep 14, 2023

Python 3.7 hit EOL (end of life) in June: https://endoflife.date/python

I'm not aware of any 3.7-specific language constructs that we're specifically maintaining, but it might be nice to drop official support (CI) anyway to try to encourage users to update.

@ewels ewels added the core: infrastructure Something to do with the MultiQC infra label Sep 14, 2023
@ewels
Copy link
Member Author

ewels commented Sep 19, 2023

This needs updating in the CI, the docs, and also in the version check:
https://github.com/ewels/MultiQC/blob/f4878540c0b1e77fa419b589ec33f3a5039d17da/multiqc/multiqc.py#L477-L484

@vladsavelyev
Copy link
Member

If we drop 3.7 support, it would simplify #2113 (we would be able to use shutil.copytree(..., dirs_exist_ok=True) introduced in 3.8).

However, we are still supporting even 3.6. I'd go with dropping both 3.6 and 3.7 in 1.17.

@ewels
Copy link
Member Author

ewels commented Oct 22, 2023

Done in #2121 but looks like we missed that multiqc.py mention..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core: infrastructure Something to do with the MultiQC infra
Projects
None yet
2 participants